Add missing nil check to FIPS EA verification #15883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing failures when running `vault server -dev`: > panic: runtime error: invalid memory address or nil pointer dereference > [signal SIGSEGV: segmentation violation code=0x2 addr=0x20 pc=0x105c41c1c] > > goroutine 1 [running]: > github.com/hashicorp/vault/command.(*ServerCommand).parseConfig(0x140005a2180) > .../vault/command/server.go:429 +0x5c Interestingly, we do not have a test case for running the dev sever. Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy
added
bug
kitography
approved these changes
Jun 8, 2022
stevendpclark
approved these changes
Jun 8, 2022
|
Going to go ahead and merge this since its breaking UI tests, and if anyone has ideas how to improve the check in the future, we can fix it then. |
This was referenced Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing failures when running
vault server -dev:Interestingly, we do not have a test case for running the dev
sever.
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>This was broken in: #15858