-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Support for Okta Number Challenge #15998
Merged
linda9379
merged 19 commits into
main
from
ui/VAULT-5417/ui_support_for_okta_number_challenge
Aug 10, 2022
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8f37494
Imported uuid library for initial commit to push a clean branch.
linda9379 6a76020
Removed import statement in auth-form file since it was causing UI te…
linda9379 75185d6
Added nonce field to payload for okta sign in. (#16001)
linda9379 a64f326
Removed uuid library since decided to use crypto.randomUUID() instead…
linda9379 449b6cd
Merge branch 'ui/VAULT-5417/ui_support_for_okta_number_challenge' of …
linda9379 189bedd
Create polling function for correct answer in okta number challenge (…
linda9379 61bd21b
Create component for okta number challenge screen (#16195)
linda9379 9d1246c
Implement error handling and screens for okta number challenge (#16276)
linda9379 77e49b0
Imported uuid library for initial commit to push a clean branch.
linda9379 47a165b
Removed import statement in auth-form file since it was causing UI te…
linda9379 0432eec
Removed uuid library since decided to use crypto.randomUUID() instead…
linda9379 20012eb
Added nonce field to payload for okta sign in. (#16001)
linda9379 3b074e4
Create polling function for correct answer in okta number challenge (…
linda9379 b58c0e4
Create component for okta number challenge screen (#16195)
linda9379 ec43431
Implement error handling and screens for okta number challenge (#16276)
linda9379 1f0faff
Merge branch main branch to ui/VAULT-5471/ui_support_for_okta_number_…
linda9379 88d87e4
Merge branch 'main' into ui/VAULT-5417/ui_support_for_okta_number_cha…
linda9379 5b474c3
UI/vault 7312/fix vault enterprise error for okta number challenge (#…
linda9379 368f64e
Added changelog
linda9379 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
```release-note:feature | ||
ui: UI support for Okta Number Challenge. | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
import Component from '@glimmer/component'; | ||
|
||
/** | ||
* @module OktaNumberChallenge | ||
* OktaNumberChallenge components are used to display loading screen and correct answer for Okta Number Challenge when signing in through Okta | ||
* | ||
* @example | ||
* ```js | ||
* <OktaNumberChallenge @correctAnswer={this.oktaNumberChallengeAnswer} @hasError={this.error} @onReturnToLogin={this.returnToLoginFromOktaNumberChallenge}/> | ||
* ``` | ||
* @param {number} correctAnswer - The correct answer to click for the okta number challenge. | ||
* @param {boolean} hasError - Determines if there is an error being thrown. | ||
* @param {function} onReturnToLogin - Sets waitingForOktaNumberChallenge to false if want to return to main login. | ||
*/ | ||
|
||
export default class OktaNumberChallenge extends Component { | ||
get oktaNumberChallengeCorrectAnswer() { | ||
return this.args.correctAnswer; | ||
} | ||
|
||
get errorThrown() { | ||
return this.args.hasError; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋🏻 (@cinthiaconti maybe?) This changelog entry isn't correctly formatted for new features.
**UI Okta Number Challenge**: <text>
You can check out the 1.11 changelog for a reference, and there's also a wiki page about this. Could someone please update this file on main so that it formats correctly in the final version of the 1.12 changelog?