Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of UI Remove recent instances of sessionStorage into release/1.11.x #16171

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Backport of UI Remove recent instances of sessionStorage into release/1.11.x #16171

merged 1 commit into from
Jun 28, 2022

Conversation

hc-github-team-secure-vault-core
Copy link
Contributor

Backport

This PR is auto-generated from #16170 to be assessed for backporting due to the inclusion of the label backport/1.11.x.

The below text is copied from the body of the original PR.

This PR removes remaining references to sessionStorage. Here's what happened:

  1. We swapped localStorage in favor of sessionStorage in UI: Switch usage of localStorage to sessionStorage #14054
  2. OIDC bugfix in OIDC Logout Bug #14545 used sessionStorage because that's what was standard at the time
  3. Team realized the move to sessionStorage was a mistake, and reverted 14054 in Revert UI: replace localStorage with sessionStorage #15769
  4. Changes from 14545 are still present in 1.11 onward, and this PR is to fix that.
Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/remove-session-storage/seriously-electric-ocelot branch from 2138055 to 2cba84a Compare June 28, 2022 17:04
@hashishaw hashishaw enabled auto-merge (squash) June 28, 2022 17:12
@hashishaw hashishaw merged commit 2ebfcb7 into release/1.11.x Jun 28, 2022
@hashishaw hashishaw deleted the backport/ui/remove-session-storage/seriously-electric-ocelot branch June 28, 2022 18:37
@hashishaw hashishaw added this to the 1.11.1 milestone Jun 28, 2022
@hashishaw hashishaw added the ui label Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashishaw hashishaw hashishaw approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
1.11.1
Development

Successfully merging this pull request may close these issues.
2 participants
@hc-github-team-secure-vault-core @hashishaw