Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow old certs to be cross-signed #16494

Merged
merged 4 commits into from
Aug 3, 2022
Merged

Commits on Jul 29, 2022

  1. Allow old certs to be cross-signed

    In Vault 1.11, we introduced cross-signing support, but the earlier SKID
    field change in Vault 1.10 causes problems: notably, certs created on
    older versions of Vault (<=1.9) or outside of Vault (with a different
    SKID method) cannot be cross-signed and validated in OpenSSL.
    
    In particular, OpenSSL appears to be unique in requiring a SKID/AKID
    match for chain building. If AKID and SKID are present on an otherwise
    valid client/parent cert pair and the values are different, OpenSSL will
    not build a valid path over those two, whereas most other chain
    validation implementations will.
    
    Regardless, to have proper cross-signing support, we really aught to
    support copying an SKID. This adds such support to the sign-intermediate
    endpoint. Support for the /issue endpoint is not added, as cross-signing
    leaf certs isn't generally useful and can accept random SKIDs.
    
    Resolves: #16461
    
    Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    cipherboy committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    a45c70e View commit details
    Browse the repository at this point in the history
  2. Add changelog

    Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    cipherboy committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    25f0cd9 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. Address review feedback, fix tests

    Also adds a known-answer test using LE R3 CA's SKID.
    
    Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    cipherboy committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    45d678e View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. Address review feedback regarding separators

    Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
    cipherboy committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    ea5a78e View commit details
    Browse the repository at this point in the history