Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/ fix tooltip submitting form #16659

Merged
merged 3 commits into from
Aug 10, 2022
Merged

Conversation

hellobontempo
Copy link
Contributor

@hellobontempo hellobontempo commented Aug 9, 2022

Small PR to fix the InfoToolTip in form field labels submitting the form. My suspicion is it was introduced when we upgraded to 3.28 and refactored the component here #14816

Before:
tooltip-bug

After
tooltip-bug

@hellobontempo hellobontempo added ui bug Used to indicate a potential bug backport/1.11.x labels Aug 9, 2022
@hellobontempo hellobontempo added this to the 1.11.3 milestone Aug 9, 2022
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I don't think we do this anywhere though I have seen designs for it where we argued to not put links in tooltips, but in case there is a tooltip with a link maybe this might effect that? You're applying the click action on the trigger and not on the content so I think we're safe, but I thought I'd throw that out there in case you can think of any situations you've come across.

@hellobontempo
Copy link
Contributor Author

Thank you! I don't think we do this anywhere though I have seen designs for it where we argued to not put links in tooltips, but in case there is a tooltip with a link maybe this might effect that? You're applying the click action on the trigger and not on the content so I think we're safe, but I thought I'd throw that out there in case you can think of any situations you've come across.

I saw an attribute where you can pass a link to a tooltip, which is why the hover delay was added.

It passed all the tests, but before backporting I'll do some smoke testing

@hellobontempo hellobontempo deleted the ui/fix-info-tooltip-submit branch August 12, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants