Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ added redis elasticache as a built-in plugin #17075

Merged
merged 5 commits into from
Sep 9, 2022

Conversation

maxcoulombe
Copy link
Contributor

The redis elasticache database plugin is a new secrets backend allowing vault to manage static roles for AWS ElastiCache clusters for Redis. See the repo here for full details.

This PR bundles the new plugin into the vault binary, as we do with most other database plugins.

Tested locally:

cd $PROJECT_FOLDER/vault
make dev GCFLAGS="all=-N -l"
./bin/vault server -dev -dev-root-token-id="root"

./bin/vault secrets enable database
./bin/vault write database/config/redis-db plugin_name="redis-elasticache-database-plugin" allowed_roles="*" url="${ELASTICACHE_URL}"
./bin/vault write database/static-roles/redis-role db_name="redis-db" username="vault-test" rotation_period=300s

Copy link
Contributor

@Zlaticanin Zlaticanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit for the changelog. Following the formatting, it should be something like this maybe:
**Redis Elasticache DB Plugin**: <text>
Otherwise it LGTM 👍

@maxcoulombe maxcoulombe merged commit 53cc12b into main Sep 9, 2022
@maxcoulombe maxcoulombe deleted the vault-8172-builtinRedisElasticache branch September 9, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants