Fix race in cert auth tests #17181
Merged
Fix race in cert auth tests #17181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
added
bug
sgmiller
approved these changes
Sep 16, 2022
There were two races here:
1. Tests racing against periodic func on updating the backend.
2. Tests racing internally to itself, to access the http-served
CRL data.
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy
force-pushed
the
cipherboy-fix-data-race
branch
from
917becb
to
dca8397
Compare
|
@stevendpclark @sgmiller Updated to fix the other data race within the tests, around crlBytes and serving that over the httpd reader thingy. |
|
\o/ go-race is now green! |
stevendpclark
approved these changes
Sep 19, 2022
|
Thanks! Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This race was added in #17136 but doesn't affect the shipped binary as it exists solely in the tests. The test would race against the periodic func for access to these variables.
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>