Bug Fix for Kymgmt keyType on default #17407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zofskeez
approved these changes
Oct 4, 2022
Comment on lines
+79
to
+86
| test('it defaults to keyType rsa-2048', async function (assert) { | ||
| assert.expect(1); | ||
| const store = this.owner.lookup('service:store'); | ||
| this.model = store.createRecord('keymgmt/key'); | ||
| this.set('mode', 'create'); | ||
| await render(hbs`<Keymgmt::KeyEdit @model={{model}} @mode={{mode}} /><div id="modal-wormhole" />`); | ||
| assert.dom('[data-test-input="type"]').hasValue('rsa-2048', 'Has type rsa-2048 by default'); | ||
| }); |
This was referenced Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the first possibleValue was being populated in the dropdown Key Type but because no change event was triggered on init the
defaultValueofrsa-2048was being sent, not the value shown. Setting thedefaultValueto match the API fixes this.Note:
defaultValueis a attr on the ember data model. So though our form-field.hbs component does not set the defaultValue if one is specified, the model automatically adds it because it's an ember attribute.Ran enterprise test locally and all are passing.