Intercept key_id from generic configmap and turn it into a wrapperv2 option #17612
Conversation
There was a problem hiding this comment.
Something feels wrong, or I'm missing something...
Looking at the docs for seal configuration only OCI uses the key_id configuration field so why are we applying it to all the wrappers now? AliCloud and AWS both use kms_key_id which seem to be handled properly in the v2 code.
Technically this should be fixed within the ocikms.go I think but we could workaround it here as well to save from cutting a new version of go-kms-wrapping.
That's good to know, and explains why it hasn't tripped up more KMSes. I addressed it this way because of Wrapper v2 having a generic keyId property. Technically I could just put that in the switch statement for OCIKMS. |
Wrapper v2 has a dedicated option for KeyID. But we handle seal config
generically. We need to catch this in the config map and convert it to the
new option.