OIDC Alternate Path Bug #17661
Merged
OIDC Alternate Path Bug #17661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bug where role wasn't being retained when using alternate oidc mount path at login
Monkeychip
reviewed
Oct 26, 2022
Monkeychip
reviewed
Oct 26, 2022
Monkeychip
reviewed
Oct 26, 2022
Monkeychip
reviewed
Oct 26, 2022
Monkeychip
approved these changes
Oct 26, 2022
zofskeez
commented
Oct 26, 2022
| {{#if (or (this.error) (and this.waitingForOktaNumberChallenge (not this.cancelAuthForOktaNumberChallenge)))}} | ||
| {{#if (and this.waitingForOktaNumberChallenge (not this.cancelAuthForOktaNumberChallenge))}} |
There was a problem hiding this comment.
I noticed while testing error handling in AuthJwt that this was catching all errors and also throwing an error of it's own since it was trying to lookup this.error as a helper. It doesn't look like the error prop is relevant for the condition so I removed it.
This was referenced Oct 26, 2022
zofskeez
added a commit
that referenced
this pull request
Oct 27, 2022
* adds error handling to auth-jwt component for missing roles and fixes bug where role wasn't being retained when using alternate oidc mount path at login * fixes jwt login bug from auth mount tabs and adds test * updates okta-number-challenge success value to arg in template * adds changelog entry * fixes issues logging in manually with jwt * reverts mistaken change
zofskeez
added a commit
that referenced
this pull request
Oct 27, 2022
* adds error handling to auth-jwt component for missing roles and fixes bug where role wasn't being retained when using alternate oidc mount path at login * fixes jwt login bug from auth mount tabs and adds test * updates okta-number-challenge success value to arg in template * adds changelog entry * fixes issues logging in manually with jwt * reverts mistaken change
zofskeez
added a commit
that referenced
this pull request
Oct 27, 2022
* adds error handling to auth-jwt component for missing roles and fixes bug where role wasn't being retained when using alternate oidc mount path at login * fixes jwt login bug from auth mount tabs and adds test * updates okta-number-challenge success value to arg in template * adds changelog entry * fixes issues logging in manually with jwt * reverts mistaken change
zofskeez
added a commit
that referenced
this pull request
Oct 27, 2022
* adds error handling to auth-jwt component for missing roles and fixes bug where role wasn't being retained when using alternate oidc mount path at login * fixes jwt login bug from auth mount tabs and adds test * updates okta-number-challenge success value to arg in template * adds changelog entry * fixes issues logging in manually with jwt * reverts mistaken change
zofskeez
added a commit
that referenced
this pull request
Oct 27, 2022
* adds error handling to auth-jwt component for missing roles and fixes bug where role wasn't being retained when using alternate oidc mount path at login * fixes jwt login bug from auth mount tabs and adds test * updates okta-number-challenge success value to arg in template * adds changelog entry * fixes issues logging in manually with jwt * reverts mistaken change
zofskeez
added a commit
that referenced
this pull request
Oct 27, 2022
* adds error handling to auth-jwt component for missing roles and fixes bug where role wasn't being retained when using alternate oidc mount path at login * fixes jwt login bug from auth mount tabs and adds test * updates okta-number-challenge success value to arg in template * adds changelog entry * fixes issues logging in manually with jwt * reverts mistaken change
zofskeez
added a commit
that referenced
this pull request
Oct 27, 2022
* adds error handling to auth-jwt component for missing roles and fixes bug where role wasn't being retained when using alternate oidc mount path at login * fixes jwt login bug from auth mount tabs and adds test * updates okta-number-challenge success value to arg in template * adds changelog entry * fixes issues logging in manually with jwt * reverts mistaken change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues with error handling within the OIDC login workflow and fixes a bug with the inputted role not being retained when attempting to login at an alternate mount path. This was brought up in issue #14671 where it was also pointed out that logging in with the jwt auth method using the mount tabs was returning an error which has also been fixed.
Alternate mount path issue as observed in 1.12.0:
After clicking the sign in button numerous times it appears that nothing happens, when in reality the
roleis not passed in the request for theauth_urland the check for that returns out of the function without any communication to the user.After updates:
The
foorole doesn't exist for thefoo-oidcpath and now an error is displayed. Next, thebarrole does not have aredirect_urifor the pathfoo-oidc. Once theauth_urlis available we can now login as expected.