Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the error and http code clearer when supplying wrong unseal key #17836

Merged
merged 8 commits into from
Nov 29, 2022
Merged

Make the error and http code clearer when supplying wrong unseal key #17836

merged 8 commits into from
Nov 29, 2022

Commits on Nov 7, 2022

  1. Fix typos

    Niklas Simons committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    cd1cb9b View commit details
    Browse the repository at this point in the history

  2. Return http 400 when wrong unseal key is supplied

    Niklas Simons committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    374af24 View commit details
    Browse the repository at this point in the history

  3. Add changelog

    Niklas Simons committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    fcac767 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. Add test cases and change one more return case to http 400 

    The new case is triggered when key length is within valid range
[16, 32], but it has uneven bytes, causing crypto/aes to return
invalid key size.
    Niklas Simons committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    d30f662 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2022

  1. remove expected in unit tests

    Niklas Simons committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    0014d2c View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. include error in the new error reason

    Niklas Simons committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    b0aef80 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. add multikey and autoseal test cases

    Niklas Simons committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    0a08279 View commit details
    Browse the repository at this point in the history

  2. return invalid key for few more code paths

    Niklas Simons committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    2638fe7 View commit details
    Browse the repository at this point in the history