Don't return a 204 if there's no historical data #17935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccapurso
approved these changes
Nov 15, 2022
Comment on lines
+1549
to
+1551
| // If the storedQuery is nil, that means there's no historical data to process. But, it's possible there's | ||
| // still current month data to process, so rather than returning a 204, let's proceed along like we're | ||
| // just querying the current month. |
There was a problem hiding this comment.
Thank you for the comment documenting this scenario!
This was referenced Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a Vault instance only had client count data for the current month, and you queried the activity log endpoint using dates that spanned historical data, you'd just get a 204 empty response. Now, instead, you get back the client counts for the current month. A concrete example might make things clearer:
Today is November 14. My Vault server came online for the first time on November 2. I've been using it ever since. If I query the activity log endpoint for 11/1/22 - 11/14/22, all is well. I get back partial results for this month. But, if I query for 10/1/22 - 11/14/22, previously I would get a 204 empty response. That's not correct though. I do have client count information for the time range requested, it's just all in November. With this patch, if I query for 10/1/22 - 11/14/22, I'll get back the same results that I would've gotten back had I queried from 11/1 - the partial results for November.