Link OSS #18228
Link OSS #18228
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| grpcServer := grpc.NewServer( | ||
| grpc.KeepaliveParams(keepalive.ServerParameters{ | ||
| Time: 2 * time.Second, | ||
| }), | ||
| grpc.MaxSendMsgSize(math.MaxInt32), | ||
| grpc.MaxRecvMsgSize(math.MaxInt32), | ||
| ) |
Check failure
Code scanning / Semgrep Scanner
Found an insecure gRPC server without 'grpc.Creds()' or options with credentials. This allows for a connection without encryption to this server. A malicious attacker could tamper with the gRPC message, which could compromise the machine. Include credentials derived from an SSL certificate in order to create a secure gRPC connection. You can create credentials using 'credentials.NewServerTLSFromFile("cert.pem", "cert.key")'.
| grpcServer := grpc.NewServer( | ||
| grpc.KeepaliveParams(keepalive.ServerParameters{ | ||
| Time: 2 * time.Second, | ||
| }), | ||
| grpc.MaxSendMsgSize(math.MaxInt32), | ||
| grpc.MaxRecvMsgSize(math.MaxInt32), | ||
| ) |
Check failure
Code scanning / Semgrep Scanner
Found an insecure gRPC server without 'grpc.Creds()' or options with credentials. This allows for a connection without encryption to this server. A malicious attacker could tamper with the gRPC message, which could compromise the machine. Include credentials derived from an SSL certificate in order to create a secure gRPC connection. You can create credentials using 'credentials.NewServerTLSFromFile("cert.pem", "cert.key")'.
| @@ -0,0 +1,46 @@ | |||
| syntax = "proto3"; | |||
There was a problem hiding this comment.
Just raising an idea here. We have a subdirectory for node status protobuf file. Would it make sense to move all protobuf files for other capabilities there too?
There was a problem hiding this comment.
Yup, that was my thinking too. We'll definitely need to do that but was thinking of doing it in a separate PR. I didn't want to introduce too many structural changes yet.
|
Looks great! Just posted a couple refactoring comments. |
|
* add Link config, init, and capabilities * add node status proto * bump protoc version to 3.21.9 * make proto * adding link tests * remove wrapped link * add changelog entry * update changelog entry
No description provided.