Add description for VaultSharp client library #18298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rajanadar
commented
Dec 9, 2022
rajanadar
commented
- Calling out features and cross platform capabilities
- Along with Enterprise Vault support for enterprise vault users
calling our features and cross platform capabilities along with Enterprise Vault support for enterprise vault users
|
@rajanadar is attempting to deploy a commit to the HashiCorp Team on Vercel. A member of the Team first needs to authorize it. |
tjperry07
suggested changes
Dec 9, 2022
Comment on lines
54
to
57
| - [VaultSharp](https://github.com/rajanadar/VaultSharp) (The most comprehensive cross-platform .NET Library for Vault) | ||
| - Supports all Auth and Secret backends supported by Vault including Enterprise features of Vault. | ||
| - Truly cross platform: Supports .NET 5, .NET 6, .NET Framework 4.x, .NET Standard 2.x/1.x, mac/iOS, Android, UWP, Mono, Xamarin etc. | ||
| - With extensive documentation and code samples at https://rajanadar.github.io/VaultSharp |
There was a problem hiding this comment.
Suggested change
| - [VaultSharp](https://github.com/rajanadar/VaultSharp) (The most comprehensive cross-platform .NET Library for Vault) | |
| - Supports all Auth and Secret backends supported by Vault including Enterprise features of Vault. | |
| - Truly cross platform: Supports .NET 5, .NET 6, .NET Framework 4.x, .NET Standard 2.x/1.x, mac/iOS, Android, UWP, Mono, Xamarin etc. | |
| - With extensive documentation and code samples at https://rajanadar.github.io/VaultSharp | |
| - [VaultSharp](https://github.com/rajanadar/VaultSharp) | |
| - Supports .NET 5, .NET 6, .NET Framework 4.x, .NET Standard 2.x/1.x, mac/iOS, Android, UWP, Mono, Xamarin. |
Let's keep these to a minimum to match the other descriptions. Make sure to keep your readme updated with the correct information.
There was a problem hiding this comment.
Let's keep these to a minimum to match the other descriptions. Make sure to keep your readme updated with the correct information.
got it. made the change
VioletHynes
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.