Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: unload auth method when navigating away from form #18651

Merged
merged 4 commits into from
Jan 12, 2023
Merged

ui: unload auth method when navigating away from form #18651

merged 4 commits into from
Jan 12, 2023

Conversation

hellobontempo
Copy link
Contributor

before fix:
auth-bug

@hellobontempo hellobontempo added this to the 1.13.0-rc1 milestone Jan 10, 2023
@hellobontempo hellobontempo modified the milestones: 1.13.0-rc1, 1.12.3 Jan 10, 2023
zofskeez
zofskeez approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@hellobontempo hellobontempo merged commit 9752352 into main Jan 12, 2023
Closed
@hellobontempo hellobontempo mentioned this pull request Jan 12, 2023
Merged
@hellobontempo hellobontempo deleted the ui/VAULT-12615/auth-method-unload-record-fix branch January 12, 2023 23:05
AnPucel pushed a commit that referenced this pull request Feb 3, 2023
@hellobontempo @AnPucel
ui: unload auth method when navigating away from form (#18651)
e4d15f7 
* unload record instead of rollback

* unload record instead of rollback

* add changelog

* add rollback attrs back if record is not new
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zofskeez zofskeez zofskeez approved these changes

Assignees
No one assigned
Labels
backport ui
Projects
None yet
Milestone
1.12.3
Development

Successfully merging this pull request may close these issues.
2 participants
@hellobontempo @zofskeez