Show generate creds for static-roles when you have read permissions #19190
Conversation
| @@ -0,0 +1,45 @@ | |||
| import { module, test } from 'qunit'; | |||
There was a problem hiding this comment.
I'll remove this file and put in another pr that will not get backported.
ui/app/models/database/role.js
Outdated
| @@ -130,6 +130,7 @@ export default Model.extend({ | |||
| credentialPath: lazyCapabilities(apiPath`${'backend'}/creds/${'id'}`, 'backend', 'id'), | |||
| staticCredentialPath: lazyCapabilities(apiPath`${'backend'}/static-creds/${'id'}`, 'backend', 'id'), | |||
| canGenerateCredentials: alias('credentialPath.canRead'), | |||
There was a problem hiding this comment.
could this be a computed instead and true if staticCredentialPath.canRead OR
credentialPath.canRead is true? that way the HBS template could still be just @model.canGenerateCredentials?
There was a problem hiding this comment.
Good idea. The type matters here. So if type is static then we have to check the static path and if type is dynamic check the dynamic path. We could still do a computed given this logic but I go back and forth on this. I think because this is a backport, and I just noticed (my bad) that the the static param already existed canGetCredentials I'll keep the changes to a minimum. The canGenerateCreds and canGetCredentials are used in another template so to use a computed I would need to amend the logic there as well. Thoughts?
There was a problem hiding this comment.
Nice catch! I see that now, good call removing!
| {{#if @model.canGenerateCredentials}} | ||
| {{#if | ||
| (or | ||
| (and (eq @model.type "static") @model.canGenerateStaticCredentials) |
There was a problem hiding this comment.
can be reverted if the above is possible!
Bug fix for showing the Generate Creds/Get Credentials button for both dynamic and static roles. Before it was only showing the button for dynamic roles.
Backporting note: If this PR is approved, I'll remove the test coverage and backport everything else 3 releases. Then I'll make another PR for just the test coverage that will not get backported. I cannot backport the test coverage because I'm using a very handy (thank you Chelsea) method for stubbing the capabilities-self endpoint that was added in the 1.13. I could have added to the existing acceptance test, but we've had problems with race conditions in that test. Additionally, the actual fix was better tested in a component test.
I won't add the backport labels until after I remove the test.
creds.mov