Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of Handle permission issue on pki health-check tune checkers into release/1.13.x #19286

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Backport of Handle permission issue on pki health-check tune checkers into release/1.13.x #19286

merged 1 commit into from
Feb 22, 2023

Conversation

hc-github-team-secure-vault-core
Copy link
Contributor

Backport

This PR is auto-generated from #19276 to be assessed for backporting due to the inclusion of the label backport/1.13.x.

The below text is copied from the body of the original PR.

  • Prior to this fix, if the end-user's Vault token did not have permission to the mount's tune api, we would return as if the tunable params had not been set.
  • Now check to see if we encountered a permission issue and report that back to the end-user like the other checks do.
Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/stevendpclark/fix-health-check-tune-audit/optionally-engaged-dragon branch 2 times, most recently from 42aa726 to a837046 Compare February 22, 2023 14:02
@stevendpclark stevendpclark added this to the 1.13.0 milestone Feb 22, 2023
@stevendpclark stevendpclark self-assigned this Feb 22, 2023
@stevendpclark stevendpclark enabled auto-merge (squash) February 22, 2023 14:03
@stevendpclark stevendpclark merged commit 871dd06 into release/1.13.x Feb 22, 2023
@stevendpclark stevendpclark deleted the backport/stevendpclark/fix-health-check-tune-audit/optionally-engaged-dragon branch February 22, 2023 14:40
@fopina-ci fopina-ci mentioned this pull request Apr 27, 2023
Closed
@fopina-ci fopina-ci mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevendpclark stevendpclark stevendpclark approved these changes

Assignees

@stevendpclark stevendpclark

Labels
None yet
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hc-github-team-secure-vault-core @stevendpclark