Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity manager secure context fallback #19403

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

zofskeez
Copy link
Contributor

@zofskeez zofskeez commented Feb 28, 2023

This PR removes crypto and adds the uuid package since crypto is only available in secure contexts.

crytpo.randomUUID() was used to set an id for dr and performance replication attribute records returned on the cluster since there is no unique key for Ember Data to store the record. It was also used for the nonce value when logging in with the okta auth method when a number challenge is required.

Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants