Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass encodeBase64 param to transit-key-actions #19429

Merged
merged 3 commits into from
Mar 6, 2023

Conversation

Monkeychip
Copy link
Contributor

@Monkeychip Monkeychip commented Mar 2, 2023

A fix for the GH Issue here.

We missed passing the encodeBase64 param to the doSubmit action on hmac.hbs. You can see from other transit-key-action forms that show this option they pass this param in the hash to this action.

Added test coverage with minimal changes so the fix can be backported.

The checkbox under codemirror was the checkbox in question.
image

Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants