UI: fix enterprise test failures #19671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rp/vault into ui/fix-oidc-ns-test-failures-ent
zofskeez
reviewed
Mar 22, 2023
Comment on lines
58
to
60
| const zone = new Date().toLocaleTimeString(undefined, { timeZoneName: 'short' }).split(' ')[2]; | ||
| const zone = new Date(timestampDate) | ||
| .toLocaleTimeString(undefined, { timeZoneName: 'short' }) | ||
| .split(' ')[2]; |
There was a problem hiding this comment.
This was failing locally since the new Date was in MDT while the timestampDate was MST.
There was a problem hiding this comment.
I ran into this too 🤦 Although I think I re-wrote this test as part of #19521 (now merged) so maybe a rebase is in order?
hellobontempo
added a commit
that referenced
this pull request
Mar 22, 2023
* move oidc tests into new file * remove module from namespace test * remove entered line * add logout to afterEach hook * remove ns test * move test setup to within test * use logout.visit() instead * updates oidc auth namespaces test * reverts to authPage logout --------- Co-authored-by: Jordan Reimer <zofskeez@gmail.com>
hellobontempo
added a commit
that referenced
this pull request
Mar 23, 2023
…is inputted, prior to OIDC auth #19541 (#19661) * UI/update auth form to fetchRoles after a namespace is inputted, prior to OIDC auth (#19541) * re-fetch roles if there is a namespace * remove redundant conditional * reorder oidc auth operations * add test * test cleanup * add changelog * UI: fix enterprise test failures (#19671) * move oidc tests into new file * remove module from namespace test * remove entered line * add logout to afterEach hook * remove ns test * move test setup to within test * use logout.visit() instead * updates oidc auth namespaces test * reverts to authPage logout --------- Co-authored-by: Jordan Reimer <zofskeez@gmail.com> --------- Co-authored-by: Jordan Reimer <zofskeez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran the tests locally on enterprise after the latest changes:
