Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of Update the if conditions for test-go jobs in CI into release/1.11.x #19870

Merged
merged 3 commits into from
Apr 3, 2023
Merged

Backport of Update the if conditions for test-go jobs in CI into release/1.11.x #19870

merged 3 commits into from
Apr 3, 2023

Conversation

hc-github-team-secure-vault-core
Copy link
Contributor

Backport

This PR is auto-generated from #19809 to be assessed for backporting due to the inclusion of the label backport/1.11.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.

⚠️ This will need to be rebased on main once PR #19807 is merged in.

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/kubawi-fix-if-conditions-in-test-go-jobs-in-ci/uniformly-driving-cockatoo branch from 07e56f9 to 2dacb4a Compare March 30, 2023 20:28
@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/kubawi-fix-if-conditions-in-test-go-jobs-in-ci/uniformly-driving-cockatoo branch from 2dacb4a to 07e56f9 Compare March 30, 2023 20:28
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 30, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@marcboudreau marcboudreau marked this pull request as ready for review March 30, 2023 20:40
@marcboudreau marcboudreau requested a review from a team as a code owner March 30, 2023 20:40
@marcboudreau marcboudreau enabled auto-merge (squash) March 30, 2023 21:04
kubawi
kubawi approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@kubawi kubawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kubawi kubawi force-pushed the backport/kubawi-fix-if-conditions-in-test-go-jobs-in-ci/uniformly-driving-cockatoo branch from d77677f to 82c4403 Compare April 3, 2023 11:58
@marcboudreau marcboudreau merged commit 23e12f4 into release/1.11.x Apr 3, 2023
@kubawi kubawi deleted the backport/kubawi-fix-if-conditions-in-test-go-jobs-in-ci/uniformly-driving-cockatoo branch April 14, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubawi kubawi kubawi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hc-github-team-secure-vault-core @hashicorp-cla @kubawi @marcboudreau