VAULT-14734: activity log write endpoint #20019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miagilepner
force-pushed
the
miagilepner/VAULT-14734-activity-log-write-endpoint
branch
from
b002e32
to
5ef2146
Compare
hghaf099
reviewed
Apr 11, 2023
raskchanky
reviewed
Apr 11, 2023
raskchanky
deleted the
miagilepner/VAULT-14734-activity-log-write-endpoint
branch
This was referenced Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a no-op endpoint at
sys/internal/counters/activity/writefor writing activity log data when Vault is compiled with thetestonlybuild tag. This endpoint accepts JSON input for the data to write to the activity log.The input is defined as protobuf and Go models are generated from the protobuf for simplicity's sake - there are several "oneof" options in the input, and protobuf gives a built-in way to handle those restrictions.
Currently, the endpoint only validates the input. A later PR will update the handler to generate and write the data.