Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add walkSecretsTree helper function #20464

Merged
merged 6 commits into from
May 2, 2023
Merged

Add walkSecretsTree helper function #20464

merged 6 commits into from
May 2, 2023

Conversation

averche
Copy link
Contributor

@averche averche commented May 2, 2023 •
edited
Loading

The walkSecretsTree helper function will be used by vault agent generate-config to produce a recursive list of secrets rooted at the given path. The output of walkSecretsTree is DFS sorted by keys at each level.

@averche averche added this to the 1.14 milestone May 2, 2023
@averche averche changed the title Add listRecursive helper function Add listSecretsRecursive helper function May 2, 2023
@averche averche requested a review from a team May 2, 2023 15:55
dhuckins
dhuckins approved these changes May 2, 2023
View reviewed changes
command/kv_helpers.go Outdated Show resolved Hide resolved
command/kv_helpers.go Show resolved Hide resolved
@averche averche changed the title Add listSecretsRecursive helper function Add walkSecretsTree helper function May 2, 2023
dhuckins
dhuckins approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@dhuckins dhuckins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like this better

@averche averche merged commit d5f7311 into main May 2, 2023
@averche averche deleted the recurse-helper branch May 2, 2023 19:23
@averche averche mentioned this pull request May 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhuckins dhuckins dhuckins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.
2 participants
@averche @dhuckins