Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Capture loop var in TestClientDisabledRedirects into release/1.13.x #20468

Merged

Conversation

hc-github-team-secure-vault-core
Copy link
Contributor

Backport

This PR is auto-generated from #20466 to be assessed for backporting due to the inclusion of the label backport/1.13.x.

The below text is copied from the body of the original PR.


Without this change, test failures only report the last value of name:

 /Users/mpalmi/scm/vault-enterprise/api/client_test.go:258: Disabled redirects: Moved permanently: expected 3 request(s) but got 1
    /Users/mpalmi/scm/vault-enterprise/api/client_test.go:258: Disabled redirects: Moved permanently: expected 5 request(s) but got 1
    /Users/mpalmi/scm/vault-enterprise/api/client_test.go:258: Disabled redirects: Moved permanently: expected 4 request(s) but got 1
    /Users/mpalmi/scm/vault-enterprise/api/client_test.go:258: Disabled redirects: Moved permanently: expected 6 request(s) but got 2

Capturing the loop var results in the following output:

  /Users/mpalmi/scm/vault-enterprise/api/client_test.go:258: Disabled redirects: Temporary Redirect: expected 5 request(s) but got 1
    /Users/mpalmi/scm/vault-enterprise/api/client_test.go:258: Disabled redirects: Found: expected 4 request(s) but got 1
    /Users/mpalmi/scm/vault-enterprise/api/client_test.go:258: Disabled redirects: Moved permanently: expected 3 request(s) but got 1
    /Users/mpalmi/scm/vault-enterprise/api/client_test.go:258: Enable redirects: Moved permanently: expected 6 request(s) but got 2

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/capture-loop-var/repeatedly-present-buffalo branch 2 times, most recently from eb1bf54 to cd3bbfa Compare May 2, 2023 18:11
@mpalmi mpalmi enabled auto-merge (squash) May 2, 2023 18:11
@mpalmi mpalmi merged commit fccc00a into release/1.13.x May 2, 2023
@mpalmi mpalmi deleted the backport/capture-loop-var/repeatedly-present-buffalo branch May 3, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants