Backport of Vault-12308: Change password policy testing to be deterministic into release/1.13.x #20632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/vault-12308-pwd/lively-solid-chamois
branch
from
99f55c1
to
40dd39d
Compare
hc-github-team-secure-vault-core
force-pushed
the
backport/vault-12308-pwd/lively-solid-chamois
branch
from
876fd66
to
90a605b
Compare
rculpepper
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20625 to be assessed for backporting due to the inclusion of the label backport/1.13.x.
The below text is copied from the body of the original PR.
This changes the password policy testing to attempt to construct a test password rather than generating random passwords and checking them against the rules. This stops Vault from erroring out on policies that are restrictive, but still possible.
Overview of commits