Add initial ACME API documentation #20752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy
commented
May 24, 2023
The required header `Cache-Control: no-store` is automatically set by Vault in wrapGenericHandler(...). Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy
force-pushed
the
cipherboy-add-api-docs-for-acme
branch
from
27d031d
to
21b14de
Compare
| specified, | ||
|
|
||
| - `new-account-required`, where new accounts are required to have EAB | ||
| but existing accounts can still be used, and |
There was a problem hiding this comment.
Sentence wasn't completed?
There was a problem hiding this comment.
Nah, it was just a continued list. item one, / item-two, and / item-three. :-)
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
stevendpclark
approved these changes
May 26, 2023
kitography
approved these changes
May 26, 2023
|
|
||
| ### List Unused ACME EAB Binding Tokens | ||
|
|
||
| This endpoint returns a list of all unused ACME binding tokens; once used, |
There was a problem hiding this comment.
This is authed, right? (maybe say, "this authenticated endpoint")
There was a problem hiding this comment.
We usually only list unauthenticated endpoints; its assumed endpoints are authed by default. I've added a missing note to the Directories that it is unauthed from a Vault auth perspective though. :-) thanks!
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation about the new ACME APIs in the PKI engine!
For ticket: VAULT-13857.