Address Test-ui suite failure for package install issues #20756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkeychip
commented
May 24, 2023
.github/workflows/ci.yml
Outdated
| - id: install-browser-libraries | ||
| run: sudo apt install -y libnss3-dev libgdk-pixbuf2.0-dev libgtk-3-dev libxss-dev libasound2 | ||
| # - id: install-browser-libraries | ||
| # run: sudo apt update && sudo apt install -y libnss3-dev libgdk-pixbuf2.0-dev libgtk-3-dev libxss-dev libasound2 |
There was a problem hiding this comment.
If this works, I'll remove 230-231, just doing a test.
This was referenced May 24, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another option: to remove the packages instead. Release team did a test run on their end and it worked without it. The id seems to indicate that these are for browser actions and the test will run without them. Running this option on the third commit to also test. Second commit is with the
apt update command.Note: may need to backport as recent changes in this file were also backported—see here.
See failure here.
Step for failure
Error:
Noticed the enos test had already done something to fix this issue—see here.