Bump go-plugin dep

[evan2645]

Bumps the go-plugin package to pick up a bugfix that broke our project on Windows. Our project uses the Vault SDK and we'd like to bump to the latest, but can't until the Windows bugfix is picked up.

I had some issues with the go tooling, it wasn't quite happy with the current state of go.mod. Forcing an upgrade of go-plugin to the same version that currently appears in go.mod resulted in many other dependency changes, so I resorted to editing manually ... what am I doing wrong?

Thanks in advance for your help here

[hashicorp-cla]

All committers have signed the CLA.

[maxb]

Our project uses the Vault SDK and we'd like to bump to the latest, but can't until the Windows bugfix is picked up.

Unless I've misunderstood how Go works, you should be able to just ask Go to use the new go-plugin version in your own project (go get github.com/hashicorp/go-plugin) right now, to pick up the bugfix, without needing another release of vault/sdk first.

I had some issues with the go tooling, it wasn't quite happy with the current state of go.mod.

There does appear to be something weird going on, I ended up opening golang/go#60588.

Separately, please run go mod tidy in the root directory of your branch and commit the result. You need to do this because the root directory of the Vault project includes the sdk via a local directory replace:

vault/go.mod

Line 23 in 155003a

replace github.com/hashicorp/vault/sdk => ./sdk

and you have changed the sdk's go.mod.

[evan2645]

you should be able to just ask Go to use the new go-plugin version in your own project right now, to pick up the bugfix

Ah awesome, thank you!

Separately, please run go mod tidy in the root directory of your branch and commit the result. You need to do this because the root directory of the Vault project includes the sdk via a local directory replace

Sure, just pushed that up

[tomhjp]

Thanks for raising! I added a changelog, LGTM