Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit ACME issued certificates to a max of 90 days #20981

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Limit ACME issued certificates to a max of 90 days #20981

merged 2 commits into from
Jun 6, 2023

Conversation

stevendpclark
Copy link
Contributor

@stevendpclark stevendpclark commented Jun 5, 2023 •
edited
Loading

  • If the normal NotAfter date that is calculated from the mount/issuer/role TTL values is greater than 90 days, override the value to use 90 days.

@stevendpclark
Limit ACME issued certificates to a max of 90 days
c9096a6 
 - If the normal NotAfter date that is calculated from the mount/issuer/role TTL values is greater than 90 days, override the TTL value to a 90-day value.
@stevendpclark stevendpclark self-assigned this Jun 5, 2023
@stevendpclark stevendpclark requested a review from a team June 5, 2023 13:25
cipherboy
cipherboy approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stevendpclark stevendpclark merged commit ddaf503 into main Jun 6, 2023
@stevendpclark stevendpclark deleted the stevendpclark/vault-16837-acme-90-day-ttl branch June 6, 2023 13:51
Merged
@0xtbt 0xtbt mentioned this pull request Jun 24, 2023
Open
@0xtbt 0xtbt mentioned this pull request Oct 1, 2023
Open
@0xtbt 0xtbt mentioned this pull request Nov 30, 2023
Open
@0xtbt 0xtbt mentioned this pull request Dec 19, 2023
Open
@0xtbt 0xtbt mentioned this pull request Jan 9, 2024
Open
@0xtbt 0xtbt mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipherboy cipherboy cipherboy approved these changes

@kitography kitography Awaiting requested review from kitography

Assignees

@stevendpclark stevendpclark

Labels
pr/no-milestone secret/pki
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevendpclark @cipherboy