Fix some broken links/clarify some things in the Vault Proxy docs #21262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VioletHynes
changed the title
VioletHynes
commented
Jun 15, 2023
There was a problem hiding this comment.
This wasn't highlighted in the testing, but I spotted this was missing and thought I'd add it.
schavis
approved these changes
Jun 15, 2023
miagilepner
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @miagilepner for finding some of these issues when testing! I also added some fixes to issues I found myself when I was poking around.
Docs are here, and all seems to be fixed: https://vault-3qm8zqt7a-hashicorp.vercel.app/vault/docs/agent-and-proxy