Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Remove readOnly attrs from Clients Count Config Serializer into release/1.12.x #21401

Conversation

hc-github-team-secure-vault-core
Copy link
Contributor

Backport

This PR is auto-generated from #21391 to be assessed for backporting due to the inclusion of the label backport/1.12.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@Monkeychip
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


I noticed in the flashMessage displayed after saving the config that the three attrs were mentioned. These are readOnly and thus do not need to be serialized. This is related to the census config work.

While I was in there, I "octane'ified" the serializer.

image

Backporting to last three supported versions, which misses the 1.11 which had this change. But this was not a functional bug, just cosmetic, so I think that is okay.


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/VAULT-17404/client-count-config-cleanup/hugely-fond-poodle branch 2 times, most recently from 58c2b04 to 0844b34 Compare June 22, 2023 01:29
@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@Monkeychip Monkeychip added this to the 1.12.9 milestone Jun 22, 2023
@Monkeychip Monkeychip added the ui label Jun 22, 2023
@Monkeychip Monkeychip marked this pull request as ready for review June 22, 2023 20:06
@Monkeychip Monkeychip enabled auto-merge (squash) June 22, 2023 20:06
@Monkeychip Monkeychip closed this Jun 22, 2023
auto-merge was automatically disabled June 22, 2023 20:07

Pull request was closed

@Monkeychip Monkeychip deleted the backport/ui/VAULT-17404/client-count-config-cleanup/hugely-fond-poodle branch June 22, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants