Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi: Fix response schema for PKI Issue requests #21449

Merged
merged 5 commits into from
Jun 26, 2023
Merged

Conversation

averche
Copy link
Contributor

@averche averche commented Jun 25, 2023

The response schema for pki/issue/* requests have expiration represented as int64 rather than a string.

respData := map[string]interface{}{
"expiration": int64(parsedBundle.Certificate.NotAfter.Unix()),
"serial_number": cb.SerialNumber,
}

This PR fixes the corresponding OpenAPI schema and should address hashicorp/vault-client-go#185

@averche averche added this to the 1.15 milestone Jun 25, 2023
@averche averche marked this pull request as ready for review June 25, 2023 23:25
@averche averche requested a review from a team June 25, 2023 23:25
@stevendpclark
Copy link
Contributor

Hi @averche, I think there's another expiration string field that should be changed to an Int64 based on this

@averche
Copy link
Contributor Author

averche commented Jun 26, 2023

Hi @averche, I think there's another expiration string field that should be changed to an Int64 based on this

Good catch, thanks!

Copy link
Contributor

@stevendpclark stevendpclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@averche averche merged commit df30401 into main Jun 26, 2023
90 checks passed
@averche averche deleted the pki-response-fix branch June 26, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants