Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API Explorer Link to Sidebar Nav under tools #21578

Merged
merged 8 commits into from
Jul 5, 2023

Conversation

Monkeychip
Copy link
Contributor

@Monkeychip Monkeychip commented Jul 5, 2023

This PR adds the API Explorer link to the sidebar nav, under tools. Previously the only way to open this link was to type "api" into the dev console; an unnecessary easter egg.

open-api-explorer.mov

@Monkeychip Monkeychip added the ui label Jul 5, 2023
@Monkeychip Monkeychip added this to the 1.14.1 milestone Jul 5, 2023
Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea adding a link to the api explorer in the tools nav! Just a comment regarding some cleanup on the link but otherwise looks good.

Comment on lines 23 to 24
@route="vault.cluster.tools.open-api-explorer.index"
@current-when="vault.cluster.tools.open-api-explorer.index"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled down the branch to test and you can remove .index from the route and also current-when is not necessary since the link only needs to be active when the route is navigated to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking. I'll update.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Monkeychip Monkeychip modified the milestones: 1.14.1, 1.15 Jul 5, 2023
@Monkeychip Monkeychip enabled auto-merge (squash) July 5, 2023 17:57
@Monkeychip Monkeychip merged commit 967c241 into main Jul 5, 2023
56 checks passed
@Monkeychip Monkeychip deleted the ui/VAULT-17662/open-api-link branch July 5, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants