Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: remodel shamir flow #21871

Merged
merged 26 commits into from
Jul 19, 2023
Merged

UI: remodel shamir flow #21871

merged 26 commits into from
Jul 19, 2023

Conversation

hashishaw
Copy link
Contributor

@hashishaw hashishaw commented Jul 14, 2023 •
edited
Loading

Due to changes upcoming in the latest Ember upgrade, we needed to revisit the ShamirFlow component.

Much of this work is splitting into smaller component parts. I tried to make lots of comments as I understood the flow, and to write comprehensive tests.

Unseal before/after
shamir/flow start
compare-unseal
'shamir/flow` with progress:
compare-unseal-with-progress

Generate DR Operation Token
Start shamir/dr-token-flow
compare-generate-start
PGP screen (choose-pgp-key-form)
compare-pgp-screen
PGP enter textarea (choose-pgp-key-form)
compare-pgp-type
Root key w/o OTP (shamir/form)
compare-root-key-portion
Root key w/ OTP (shamir/form)
old-generate-with-otp
new-generate-with-otp
Encode key steps (shamir/dr-token-flow)
old-generate-finish
new-generate-finish

@hashishaw hashishaw added the ui label Jul 14, 2023
@hashishaw hashishaw added this to the 1.15 milestone Jul 14, 2023
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 14, 2023
hellobontempo
hellobontempo reviewed Jul 14, 2023
View reviewed changes
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that is a lot. The comments and steps are great! I'll have to give it more of a thorough passover with a fresh brain.

If possible, could you add screenshots for each template view? It'd be helpful to have a visually reference.

ui/lib/core/addon/components/choose-pgp-key-form.hbs Outdated Show resolved Hide resolved
ui/lib/core/addon/components/shamir/form.hbs Outdated Show resolved Hide resolved
@hashishaw hashishaw marked this pull request as ready for review July 18, 2023 23:53
@github-actions
Copy link

CI Results:

All Go tests passed! ✅

@github-actions
Copy link

Build Results:
All builds succeeded! ✅

Monkeychip
Monkeychip approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple very small comments. This looks really good!

@hashishaw hashishaw enabled auto-merge (squash) July 19, 2023 23:41
@hashishaw hashishaw merged commit ad3316f into main Jul 19, 2023
93 checks passed
@hashishaw hashishaw deleted the ui/revisit-shamir-flow branch July 19, 2023 23:57
@Monkeychip Monkeychip mentioned this pull request Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellobontempo hellobontempo hellobontempo left review comments

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Milestone
1.15.0-rc1
Development

Successfully merging this pull request may close these issues.
3 participants
@hashishaw @Monkeychip @hellobontempo