-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce calls to DetermineRoleFromLoginRequest from 3 to 1 for aws auth method #22583
Merged
Merged
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
09ebcd5
reduce calls to DetermineRoleFromLoginRequest from 3 to 1 for aws aut…
elliesterner d4f4f24
change ordering of LoginCreateToken args
elliesterner 35795b1
replace another determineRoleFromLoginRequest function with role from…
elliesterner 620eee5
add changelog
elliesterner 3577e9d
Check for role in context if not there make call to DeteremineRoleFro…
elliesterner d1bf570
move context role check below nanmespace check
elliesterner bc4c23a
Merge branch 'main' into reduce-role-resolves-part1
elliesterner c3e26e3
Update changelog/22583.txt
elliesterner 1ef8b58
revert signature to same order
elliesterner 74b5182
make sure resp is last argument
elliesterner fccd664
retrieve role from context closer to where role variable is needed
elliesterner 66fb669
remove failsafe for role in mfa login
elliesterner 637b0f5
Update changelog/22583.txt
elliesterner d43a4b9
Merge branch 'main' into reduce-role-resolves-part1
elliesterner bc3daf9
Merge branch 'main' into reduce-role-resolves-part1
elliesterner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
```release-note:improvement | ||
elliesterner marked this conversation as resolved.
Show resolved
Hide resolved
|
||
core/quotas: Reduce the number of times role is calculated for rate limit and lease count quotas. | ||
elliesterner marked this conversation as resolved.
Show resolved
Hide resolved
|
||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think technically, we can changelog this as
bug
, since it's a performance regression from past versions that we're fixing.