UI: Update kv list filter to not search on type #22648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
kiannaquach
reviewed
Aug 30, 2023
kiannaquach
reviewed
Aug 30, 2023
kiannaquach
reviewed
Aug 30, 2023
| @value={{this.query}} | ||
| placeholder="Search secret path" | ||
| aria-describedby="Search by secret path" |
kiannaquach
reviewed
Aug 30, 2023
| <form {{on "submit" (perform this.handleSearch)}}> | ||
| <Hds::SegmentedGroup as |S|> |
There was a problem hiding this comment.
@hellobontempo can probably speak more to this, but should we make an hds ticket to keep track of this component being used? 🙂
kiannaquach
reviewed
Aug 30, 2023
| @@ -83,84 +89,4 @@ export default class KvListFilterComponent extends Component { | |||
| this.navigate(null, input); | |||
| } | |||
| } | |||
| /* | |||
There was a problem hiding this comment.
yay for removing some of these key events!
|
Build Results: |
Monkeychip
reviewed
Aug 30, 2023
Monkeychip
approved these changes
Aug 30, 2023
kiannaquach
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searching on type has been causing issues as of a recent Ember Upgrade, because the input loses focus each time the query param is updated (which causes a full page refresh). We had a hack to manually focus the input after page load, but found it was not working as expected within a namespace.
To reduce flakiness on this interaction, we have opted to replace the old functionality with a streamlined search bar which requires submit (or ENTER key) to search. Note that pressing the ESC key while the input is focused will direct the user to the previous "folder", as it did in the previous iterations of the nested search bar.
