Add -dev-tls-san flag #22657
Merged
Add -dev-tls-san flag #22657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is helpful when wanting to set up a dev server with TLS in Kubernetes and any other situations where the dev server may not be the same machine as the Vault client (e.g. in combination with some /etc/hosts entries)
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
cipherboy
reviewed
Aug 31, 2023
command/server.go
Outdated
| @@ -971,7 +984,7 @@ func configureDevTLS(c *ServerCommand) (func(), *server.Config, string, error) { | |||
| return nil, nil, certDir, err | |||
| } | |||
| } | |||
| config, err = server.DevTLSConfig(devStorageType, certDir) | |||
| config, err = server.DevTLSConfig(devStorageType, certDir, c.flagDevTLSSans) | |||
There was a problem hiding this comment.
One comment if you've got a minute: do you want to add the listen address here as well? I think it'd help close #18259, though we could always require the explicit SAN if we preferred... Just thinking the UX might be nice of the address+dev-tls (without dev-tls-san), but my 2c. :-)
There was a problem hiding this comment.
Nice idea! Added in 3deacb8
cipherboy
approved these changes
Aug 31, 2023
* And refactor test to give more descriptive output
|
Thanks both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helpful when wanting to set up a dev server with TLS in Kubernetes and any other situations where the dev server may not be the same machine as the Vault client (e.g. in combination with some /etc/hosts entries)