Wrap long Auth Display names in menus #26181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
andaley
approved these changes
Mar 28, 2024
| @@ -77,6 +77,10 @@ | |||
| white-space: pre-wrap; | |||
| } | |||
|
|
|||
| .overflow-wrap { | |||
There was a problem hiding this comment.
did the is-word-break class not work for this situation? asking only because i was going to suggest renaming this class to .break-word to make it more obvious which CSS rule was being applied, but i see that basically already exists. 😛
not a huge deal though since we could always add an .overflow-wrap-anywhere class helper down the line.
There was a problem hiding this comment.
Good question, and it didn't work. The white-space: pre-wrap on that helper borks things. Thanks for checking though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across this while investigating another workflow. Will backport to 1.16.1 only. While we will fix this eventually in the HDS adoption work, I wanted to tackle this now so we don't push another release waiting for that work to complete with this styling issue.
I aired on the conservative side and used a new helper instead of applying the styling to the
menu-labelclass. There is some cleanup that needs to be done for this class, and I didn't want to confuse it. Largely there are three menu-label class definitions but it's only currently being used in the user-menu component. My suspicion is that eventually we can remove this class definition as we adopt HDS.Before:
After:
