Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VAULT-25710: Audit - enforce header formatter requirement in EntryFormatter #26239

Merged
merged 7 commits into from
Apr 3, 2024
Merged

VAULT-25710: Audit - enforce header formatter requirement in EntryFormatter #26239

merged 7 commits into from
Apr 3, 2024

Conversation

peteski22
Copy link
Contributor

@peteski22 peteski22 commented Apr 2, 2024 •
edited
Loading

This PR makes changes to the EntryFormatter node so that it requires a HeaderFormatter rather than accepting it as an option.

ENT PR: https://github.com/hashicorp/vault-enterprise/pull/5680

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 2, 2024
@peteski22 peteski22 changed the title VAULT-25710: Audit - Prevent regression for unseal, enforce header formatter requirement in EntryFormatter VAULT-25710: Audit - enforce header formatter requirement in EntryFormatter Apr 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024 •
edited
Loading

Build Results:
All builds succeeded! ✅

marcboudreau
marcboudreau reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@marcboudreau marcboudreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a serious thing in vault/audited_headers.go that needs to be addressed. I'm using Comment rather than Request changes so that once it's fixed someone in your timezone can go over things and provide an Approve review.

audit/entry_formatter_test.go Outdated Show resolved Hide resolved
helper/testhelpers/corehelpers/corehelpers.go Outdated Show resolved Hide resolved
vault/audited_headers.go Outdated Show resolved Hide resolved
@peteski22 peteski22 enabled auto-merge (squash) April 3, 2024 09:48
kubawi
kubawi approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@kubawi kubawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteski22 peteski22 merged commit e0a905e into main Apr 3, 2024
86 checks passed
@peteski22 peteski22 deleted the peteski22/VAULT-25710/unseal-and-headerformatter branch April 3, 2024 09:53
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcboudreau marcboudreau marcboudreau left review comments

@kubawi kubawi kubawi approved these changes

@ccapurso ccapurso Awaiting requested review from ccapurso

Assignees
No one assigned
Labels
core/audit hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peteski22 @marcboudreau @kubawi