-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test reorg: PKI #26275
Closed
Closed
Test reorg: PKI #26275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashishaw
force-pushed
the
ui/hackweek-test-reorg--pki2
branch
from
April 4, 2024 19:36
207edc7
to
e7a1b97
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Apr 4, 2024
Build Results: |
CI Results: failed ❌ |
hashishaw
changed the base branch from
ui/hackweek-test-reorg
to
ui/test-reorg-base
April 5, 2024 13:59
hashishaw
changed the base branch from
ui/test-reorg-base
to
ui/hackweek-test-reorg
April 5, 2024 13:59
andaley
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it!
* Add readme * Rename general selectors export * reorg clients helper -- all clients tests pass * Update custom messages & dashboard selectors * Rename client count selector export * clean up .CodeMirror selectors to use helper instead * move secret-edit-toolbar helper * remove helper used only once * replace noop-all-api-requests with mirage * move policy generators into their respective folders * Move LDAP helpers * Move overrideResponse to stubs helper, rename clients helper * replace oidc-specific mirage & capabilities overrides * add secretTab and checkboxByAttr to general selectors * general-selectors are TS * fix merge conflict import * Bump message wait time for oidc auth method test * Refactor auth methods mgmt test so we don't run into a timeout * Update comment * revert acceptance tests only * don't allow mutability of array returned by supportedAuthBackends * unrevert -- remove noop-all-api-requests * remove hardcoded ?with param * Update ui/tests/_README.md Co-authored-by: Noelle Daley <noelledaley@users.noreply.github.com> * Update ui/tests/acceptance/auth-list-test.js Co-authored-by: Noelle Daley <noelledaley@users.noreply.github.com> * Update ui/tests/acceptance/auth-test.js Co-authored-by: Noelle Daley <noelledaley@users.noreply.github.com> * Update ui/tests/acceptance/settings/auth/configure/section-test.js Co-authored-by: Noelle Daley <noelledaley@users.noreply.github.com> * Update ui/tests/unit/adapters/identity/entity-test.js Co-authored-by: Noelle Daley <noelledaley@users.noreply.github.com> * Update ui/tests/unit/adapters/identity/entity-alias-test.js Co-authored-by: Noelle Daley <noelledaley@users.noreply.github.com> * replace CLIENT_COUNT as ts in tests * update assertions * move readme to docs --------- Co-authored-by: Noelle Daley <noelledaley@users.noreply.github.com>
hashishaw
force-pushed
the
ui/test-reorg-base
branch
from
April 10, 2024 14:59
b793b7f
to
b4edfe5
Compare
hashishaw
added a commit
that referenced
this pull request
Apr 10, 2024
Had to manually merge this commit: 8a099d3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original PR (#26261) got borked due to rebase so here's a new one. These changes are test updates specific to PKI, such as: