Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test reorg: PKI #26275

Closed
wants to merge 28 commits into from
Closed

Conversation

hashishaw
Copy link
Contributor

The original PR (#26261) got borked due to rebase so here's a new one. These changes are test updates specific to PKI, such as:

  • Update component selector files to be in helpers/components
  • Update exports from selectors to be named and non-default
  • Don't import and reexport spread selectors
  • Remove PKI-specific selectors where we can use the generic ones
  • Use generic selectors whenever possible
  • Move certificates to top-level pki/pki-workflow-helpers file

@hashishaw hashishaw force-pushed the ui/hackweek-test-reorg--pki2 branch from 207edc7 to e7a1b97 Compare April 4, 2024 19:36
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 4, 2024
Copy link

github-actions bot commented Apr 4, 2024

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Apr 4, 2024

CI Results: failed ❌

@hashishaw hashishaw changed the base branch from ui/hackweek-test-reorg to ui/test-reorg-base April 5, 2024 13:59
@hashishaw hashishaw changed the title UI (sidebranch) Test Reorg - PKI (try 2) Test reorg: PKI Apr 5, 2024
@hashishaw hashishaw changed the base branch from ui/test-reorg-base to ui/hackweek-test-reorg April 5, 2024 13:59
Copy link
Contributor

@andaley andaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

* Add readme

* Rename general selectors export

* reorg clients helper -- all clients tests pass

* Update custom messages & dashboard selectors

* Rename client count selector export

* clean up .CodeMirror selectors to use helper instead

* move secret-edit-toolbar helper

* remove helper used only once

* replace noop-all-api-requests with mirage

* move policy generators into their respective folders

* Move LDAP helpers

* Move overrideResponse to stubs helper, rename clients helper

* replace oidc-specific mirage & capabilities overrides

* add secretTab and checkboxByAttr to general selectors

* general-selectors are TS

* fix merge conflict import

* Bump message wait time for oidc auth method test

* Refactor auth methods mgmt test so we don't run into a timeout

* Update comment

* revert acceptance tests only

* don't allow mutability of array returned by supportedAuthBackends

* unrevert -- remove noop-all-api-requests

* remove hardcoded ?with param

* Update ui/tests/_README.md

Co-authored-by: Noelle Daley <noelledaley@users.noreply.github.com>

* Update ui/tests/acceptance/auth-list-test.js

Co-authored-by: Noelle Daley <noelledaley@users.noreply.github.com>

* Update ui/tests/acceptance/auth-test.js

Co-authored-by: Noelle Daley <noelledaley@users.noreply.github.com>

* Update ui/tests/acceptance/settings/auth/configure/section-test.js

Co-authored-by: Noelle Daley <noelledaley@users.noreply.github.com>

* Update ui/tests/unit/adapters/identity/entity-test.js

Co-authored-by: Noelle Daley <noelledaley@users.noreply.github.com>

* Update ui/tests/unit/adapters/identity/entity-alias-test.js

Co-authored-by: Noelle Daley <noelledaley@users.noreply.github.com>

* replace CLIENT_COUNT as ts in tests

* update assertions

* move readme to docs

---------

Co-authored-by: Noelle Daley <noelledaley@users.noreply.github.com>
Base automatically changed from ui/hackweek-test-reorg to ui/test-reorg-base April 10, 2024 14:37
@hashishaw
Copy link
Contributor Author

Had to manually merge this commit: 8a099d3

@hashishaw hashishaw closed this Apr 10, 2024
@hashishaw hashishaw deleted the ui/hackweek-test-reorg--pki2 branch April 10, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants