Test reorg: KV #26289
Closed
Test reorg: KV #26289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: failed ❌ |
| @@ -13,7 +13,7 @@ import consoleClass from 'vault/tests/pages/components/console/ui-panel'; | |||
| import authForm from 'vault/tests/pages/components/auth-form'; | |||
| import controlGroup from 'vault/tests/pages/components/control-group'; | |||
| import controlGroupSuccess from 'vault/tests/pages/components/control-group-success'; | |||
| import { writeSecret } from 'vault/tests/helpers/kv/kv-run-commands'; | |||
| import { writeSecret } from 'vault/tests/helpers/kv/kv-selectors'; | |||
There was a problem hiding this comment.
I thought I remembered us talking about naming files <resource>-helpers even if it's redundant since they contain helper functions and selectors?
|
|
||
| import { create } from 'ember-cli-page-object'; | ||
| import { deleteEngineCmd, runCmd } from 'vault/tests/helpers/commands'; | ||
| import { KV_LIST } from 'vault/tests/helpers/components/kv/page/list-selectors'; |
There was a problem hiding this comment.
Even though page components are technically components, they map to route templates and I would have expected these selectors to be a separate block in the kv/kv-selectors file.
I had imagined that the helpers/components/ would contain components that are reused all over the app.
hashishaw
force-pushed
the
ui/test-reorg-base
branch
from
b793b7f
to
b4edfe5
Compare
|
We can do the KV test reorg as a separate follow-on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP -- looking for feedback on whether this is the right approach