Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ldap/auth: add tests for login regressions #26327

Merged
merged 6 commits into from
Apr 10, 2024
Merged

ldap/auth: add tests for login regressions #26327

merged 6 commits into from
Apr 10, 2024

Conversation

fairclothjm
Copy link
Contributor

@fairclothjm fairclothjm commented Apr 9, 2024 •
edited
Loading

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 9, 2024
@fairclothjm fairclothjm force-pushed the VAULT-25629/ldap/auth-login-regression-tests branch from 8b920f2 to eea8a66 Compare April 9, 2024 21:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

@fairclothjm fairclothjm force-pushed the VAULT-25629/ldap/auth-login-regression-tests branch 2 times, most recently from 6164281 to 87319e1 Compare April 9, 2024 21:32
@fairclothjm fairclothjm marked this pull request as ready for review April 9, 2024 21:32
@fairclothjm fairclothjm requested a review from a team as a code owner April 9, 2024 21:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024 •
edited
Loading

Build Results:
All builds succeeded! ✅

@fairclothjm fairclothjm force-pushed the VAULT-25629/ldap/auth-login-regression-tests branch from f83027b to 6863742 Compare April 9, 2024 23:38
@fairclothjm fairclothjm enabled auto-merge (squash) April 9, 2024 23:38
@thyton thyton self-requested a review April 10, 2024 15:44
thyton
thyton approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@thyton thyton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@fairclothjm fairclothjm merged commit f2b5290 into main Apr 10, 2024
83 checks passed
@fairclothjm fairclothjm deleted the VAULT-25629/ldap/auth-login-regression-tests branch April 10, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thyton thyton thyton approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fairclothjm @thyton