UI: pin xmldom version in resolutions #26333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
andaley
changed the title
|
Build Results: |
|
CI Results: |
andaley
force-pushed
the
ui/VAULT-25217/bump-testem
branch
from
73f0a81
to
4e5ab74
Compare
andaley
changed the title
|
handling directly in #26346 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Resolves the security vulnerability surfaced in: https://github.com/hashicorp/vault-enterprise/security/dependabot/128
The vulnerability lies within
xmldom, which is ultimately set by our version ofember-cli(see "before" screenshot).Unfortunately even upgrading to
ember-cliv 4.12.2 doesn't resolve the issue since it's still using the version of testem that is using the vulnerable version ofxmldom. The latest version oftestemhas the same problem. Therefore it's best to set thexmldomversion explicitly in the resolutions block.I opted to pin to the latest release since it didn't appear that any breaking changes occurred.
📸 Screenshots
before
after
🔗 Links
See JIRA # 25217