-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIDEBRANCH]: Test reorg cleanup pt 1 #26351
Conversation
Build Results: |
@@ -56,3 +57,52 @@ module('Acceptance | OpenAPI provides expected attributes enterprise', function | |||
} | |||
); | |||
}); | |||
|
|||
function secretEngineHelper(test, secretEngine) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these helpers that we could potentially import into other files (secret sync destinations, for example) to assert expected params?
ui/tests/acceptance/secrets/backend/kubernetes/overview-test.js
Outdated
Show resolved
Hide resolved
* SPDX-License-Identifier: BUSL-1.1 | ||
*/ | ||
|
||
// TODO: separate nested into distinct exported consts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
ui/tests/helpers/components/kubernetes/page/overview-selectors.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 👏 👏 - adding -selectors
is going to make file navigation so much easier!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for tackling this!! Just a question clarifying where page selectors should be
CI Results: failed ❌ |
No description provided.