Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vault anti-patterns url in enterprise cluster design doc #26975

Merged
merged 2 commits into from
May 13, 2024

Conversation

cjobermaier
Copy link
Contributor

The URL in the https://developer.hashicorp.com/vault/docs/enterprise/cluster-design#step-2-review-anti-patterns-for-vault-configuration doesn't send the user to Vault anti-patterns. This PR will fix this URL.

@cjobermaier cjobermaier self-assigned this May 13, 2024
@cjobermaier cjobermaier requested a review from a team as a code owner May 13, 2024 15:22
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

@yhyakuna yhyakuna merged commit 01c95e0 into main May 13, 2024
32 checks passed
@yhyakuna yhyakuna deleted the docs/fix-anti-pattern-link-cluster-docs branch May 13, 2024 16:16
schavis pushed a commit that referenced this pull request May 13, 2024
schavis pushed a commit that referenced this pull request May 13, 2024
schavis added a commit that referenced this pull request May 13, 2024
…26995)

* [docs] fix lack of space character (#26830)

* fix lack of space char

https://developer.hashicorp.com/vault/docs/concepts/policies#ui-policy-requirements

`to the ui/mountsand ui/resultant-acl`

needs a space after mounts

* add nonbreaking space to help parser

add nonbreaking space to help parser

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

---------

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Add reading guide for designing Vault clusters (#26947)

* Remove duplicate nav entry

* fix url to anti patterns (#26975)

---------

Co-authored-by: Rowan Smith <86935689+rowansmithhc@users.noreply.github.com>
Co-authored-by: CJ <105300705+cjobermaier@users.noreply.github.com>
schavis added a commit that referenced this pull request May 13, 2024
…26994)

* [docs] fix lack of space character (#26830)

* fix lack of space char

https://developer.hashicorp.com/vault/docs/concepts/policies#ui-policy-requirements

`to the ui/mountsand ui/resultant-acl`

needs a space after mounts

* add nonbreaking space to help parser

add nonbreaking space to help parser

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

---------

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>

* Add reading guide for designing Vault clusters (#26947)

* Remove duplicate nav entry

* fix url to anti patterns (#26975)

---------

Co-authored-by: CJ <105300705+cjobermaier@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants