Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid panic in s3 list operation #2785

Merged
merged 1 commit into from
Jun 5, 2017
Merged

Avoid panic in s3 list operation #2785

merged 1 commit into from
Jun 5, 2017

Conversation

vishalnayak
Copy link
Member

Ping #2779

@jefferai jefferai added this to the 0.7.3 milestone Jun 5, 2017
jefferai
jefferai requested changes Jun 5, 2017
View reviewed changes
Copy link
Member

@jefferai jefferai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a check above that for to verify that page is not nil?

@jefferai jefferai merged commit a337f9f into master Jun 5, 2017
@jefferai jefferai deleted the s3-avoid-panic branch June 5, 2017 14:53
jefferai added a commit that referenced this pull request Jun 5, 2017
@jefferai
Add another nil guard to S3, follow on from #2785
c655dee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferai jefferai jefferai requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.3
Development

Successfully merging this pull request may close these issues.
2 participants
@vishalnayak @jefferai