Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions/edits #28394

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Conversation

schavis
Copy link
Contributor

@schavis schavis commented Sep 13, 2024

@schavis schavis requested a review from a team as a code owner September 13, 2024 19:10
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 13, 2024
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@jonathanfrappier jonathanfrappier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the Windows support

@schavis schavis merged commit 680832a into docs/install-updates Sep 18, 2024
23 checks passed
@schavis schavis deleted the docs/install-updates-suggestions branch September 18, 2024 17:53
schavis added a commit that referenced this pull request Sep 18, 2024
* Add set up vault service doc
* Suggestions/edits (#28394)
---------

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants