UI: Fix LDAP Mirage Handler #28432
Merged
UI: Fix LDAP Mirage Handler #28432
+195
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
hashishaw
force-pushed
the
ui/fix-ldap-mirage-handler
branch
from
c0deafb
to
4e6ef4f
Compare
|
Build Results: |
| @@ -27,7 +27,7 @@ export default class LdapLibraryDetailsAccountsPageComponent extends Component<A | |||
| @tracked checkOutTtl: string | null = null; | |||
|
|
|||
| get cliCommand() { | |||
| return `vault lease renew ad/library/${this.args.library.name}/check-out/:lease_id`; | |||
| return `vault lease renew ${this.args.library.backend}/library/${this.args.library.name}/check-out/:lease_id`; | |||
| import { Model } from 'miragejs'; | ||
|
|
||
| export default Model.extend({ | ||
| account: '', // should match ID |
There was a problem hiding this comment.
thanks for this comment!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the LDAP mirage handler so it will work with any mounted LDAP backend, and allows check-in and check-out. It also updates the tests to ensure the accounts show up in the acceptance scenario, because at some point the mirage response broke.
UI with LDAP mounted at
/ldapBefore, in
ldap-testbackend