Normalize plugin_name option for mount and enable-auth #3202
Conversation
| PluginName string `json:"plugin_name,omitempty" structs:"plugin_name,omitempty"` | ||
| } | ||
|
|
||
| type AuthConfigInput struct { |
There was a problem hiding this comment.
There are arguments against it (mostly being, maybe what we need will diverge in the future) but it seems like simply reusing MountConfigInput could be good here. This allows the same structure to be used for tuning both (ttl, maxttl, updated plugin name, etc.).
There was a problem hiding this comment.
Is ForceNoCache a property of auth mounts as well? Can the same be said for MountConfigOutput and AuthConfigOutput?
There was a problem hiding this comment.
It is. Most mounts do nothing with it, but it is technically able to be set. So -- yes.
There was a problem hiding this comment.
How about the second question, should we use MountConfigOutput for both cases then since the config params should be the same?
There was a problem hiding this comment.
The problem is that this would be an API change. But -- then we're inconsistent because you get an AuthConfigOutput with a MountConfigInput whereas for secrets you get MountConfigInput/MountConfigOutput.
Part of me says "this is a silly situation to be in already and let's just break it and be done with it" but...we probably shouldn't. So I guess, leave AuthConfigInput after all.
* oss/master: Plugin Version Update (#3275) Lazy-load plugin mounts (#3255) changelog++ changelog++ Add pki/root/sign-self-issued. (#3274) Travis, be happier please changelog++ Change auth helper interface to api.Secret. (#3263) changelog++ Try reconnecting Mongo on EOF (#3269) Don't append a trailing slash to the request path if it doesn't actually help find something (#3271) changelog++ Use TypeDurationSecond for TTL values in PKI. (#3270) changelog++ changelog++ Use net.SplitHostPort on Consul address (#3268) Normalize plugin_name option for mount and enable-auth (#3202) Updating Okta lib for credential backend (#3245) Explicitly mention that aws/aws-ec2 were unified under aws.
Fixes #3180