Compare groups case-insensitively at login time #3240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
case-insensitive but preserving.
|
All test changes pass (and fail on the previous code). |
calvn
reviewed
Aug 25, 2017
| @@ -84,6 +84,11 @@ func (b *backend) Login(req *logical.Request, username string, password string) | |||
| var allGroups []string | |||
| // Import the custom added groups from okta backend | |||
| user, err := b.User(req.Storage, username) | |||
| if err != nil { | |||
| if b.Logger().IsDebug() { | |||
There was a problem hiding this comment.
Sort of unrelated, but why do we need to check the logger's level? Does it not respect the level set with SetLevel() so that logger.Debug() doesn't print if the logger is set at a higher level?
case-insensitive. New groups will be written in lowercase.
calvn
approved these changes
Aug 25, 2017
vishalnayak
reviewed
Aug 25, 2017
| return nil, "", err | ||
| } | ||
| for _, groupName := range entries { | ||
| if strings.ToLower(groupName) == strings.ToLower(n) { |
There was a problem hiding this comment.
Can't we just look at group/+ strings.ToLower(n) and avoid looking at all the entries?
There was a problem hiding this comment.
That will only get us one possible capitalization. So if you have written "GroupFoo" before and now try to write "Groupfoo", you won't find it. With the current logic, you will.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okta groups case-insensitive but preserving.